Search Linux Wireless

Re: [PATCH RFC v4 1/2] wifi: cfg80211/mac80211: Introduce nl80211 commands to support MLD link removal offload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 8/21/2024 2:31 PM, Johannes Berg wrote:

+/**
+ * cfg80211_update_link_reconfig_remove_update - Inform userspace about
+ *	the removal status of link which is scheduled for removal
+ * @dev: the device on which the operation is requested
+ * @link_id: Link which is undergoing removal
+ * @tbtt_count: Current tbtt_count to be updated.
+ * @tsf: Beacon's timestamp value
+ * @cmd: Inform started or completed action to userspace based on the value

Might be nicer here to wrap (some of) the many args into a struct?

Sure, will group them into struct.

I also don't see a need for a return value (and you didn't document it)

johannes


I thought the return value will be useful in any error or unsupported cases, will rethink the approach and if return value is needed, will document that.

Regards
Manish Dharanenthiran




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux