Nick Morrow <usbwifi2024@xxxxxxxxx> wrote:
> On 8/22/24 19:58, Ping-Ke Shih wrote:
> > +linux-wireless
> >
> > Hi Nick,
> >
> > Please always Cc linux-wireless for rtw88 firmware.
> >
> > And subject prefix would be "rtw88: ..."
>
> Hi Ping-Ke, I am trying to resolve what you are asking for vs. the instructions at linux-firmware. Should
> the subject for V3 be:
>
> [PATCH V3] linux-firmware: rtw88: Add firmware for RTL8812AU device
Most commits excepting to mediatek's ones don't use "linux-firmware: " as prefix.
I don't want that neither. Or I miss this new rule?
>
> >
> > Nick Morrow <usbwifi2024@xxxxxxxxx> wrote:
> >> This firmware was extracted from the 20210708 - v5.13.6-23 release of
> >> the vendor driver for this device and is believed to be the latest
> >> release by Realtek. Testing of the new driver has been accomplished
> >> using this firmware. Numerous testers have been involved.
> >>
> >> Signed-off-by: Nick Morrow <USBWiFi2024@xxxxxxxxx>
> >> ---
> >> v2:
> >> - No change. Resubmitted now that the driver is in review.
> >> ---
> >> WHENCE | 1 +
> >> rtw88/README | 3 +++
> >> rtw88/rtw8812a_fw.bin | Bin 0 -> 27030 bytes
> >> 3 files changed, 4 insertions(+)
> >> create mode 100644 rtw88/rtw8812a_fw.bin
> >>
> >> diff --git a/WHENCE b/WHENCE
> >> index 8aebe56b..d6bd4814 100644
> >> --- a/WHENCE
> >> +++ b/WHENCE
> >> @@ -3270,6 +3270,7 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
> >> Driver: rtw88 - Realtek 802.11ac WLAN driver for RTL8822BE and RTL8822CE
> >>
> >> Info: Sent to Larry Finger by Realtek engineer Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx>
> >> +File: rtw88/rtw8812a_fw.bin
> >> File: rtw88/rtw8821a_fw.bin
> >
> > I failed to apply this patch, even this textual part.
> >
> > Two leading spaces before "File: rtw88/rtw8821a_fw.bin", but actually this
> > should be only one. Not sure what is wrong.
>
> I am carefully going over this patch again... while preparing a new version of the patch. I do not recall
> editing the line that has two leading spaces.
I update my linux-firmware repository to the newest:
2cdc11a7b3bf ("Merge branch 'mt7925' into 'main'")
And, add the line. The difference looks like
diff --git a/WHENCE b/WHENCE
index c18b2e0d8db9..0c03b2d03b83 100644
--- a/WHENCE
+++ b/WHENCE
@@ -3270,6 +3270,7 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
Driver: rtw88 - Realtek 802.11ac WLAN driver for RTL8822BE and RTL8822CE
Info: Sent to Larry Finger by Realtek engineer Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx>
+File: rtw88/rtw8812a_fw.bin
File: rtw88/rtw8821a_fw.bin
File: rtw88/rtw8822b_fw.bin
File: rtw88/rtw8822c_fw.bin
This is what I expect. Can you apply your patch successfully in your side?
