On Tue, Aug 20, 2024 at 03:34:12PM +0200, Francesco Dolcini wrote: > Hello Sasha, > thanks for the patches. > > Il 20 agosto 2024 13:55:25 CEST, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> ha scritto: > >This series has a bunch of cleanup and bugfix patches for the mwifiex > >driver > > > > 24 files changed, 365 insertions(+), 729 deletions(-) > > I had a quick look at the series, and it looks fine to me, I'll try to > have a proper look in the next couple of weeks. What I wonder is > what's the risk of introducing some subtle bugs because of firmware > differences, what device/firmware combination were you able to test? I tested this on a SD8978 aka iw416 SDIO card. I just tested this on a IW61x SDIO card (mainline support for this one still in my queue) and it didn't work, I'll investigate. Other than that I also have a PCIe card I'll test this on next time. I don't know there firmware versions currently, but I used the latest ones available in linux-firmware. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |