On Tue, Aug 20, 2024 at 12:12:16PM +0200, Arend van Spriel wrote: > Align with the corrected device tree bindings in brcm,bcm4329-fmac.yaml > which imposes a constraint that the compatible should have the string > "brcm,bcm4329-fmac". Additionally, please explain why do you think these devices are compatible and also how this change affects working. Considering that previously these devices were not matched by brcmf_of_probe() and now they will, this is significant change. > > Fixes: e2e37224e8b3 ("dt-bindings: net: bcm4329-fmac: Add Apple properties & chips") No, no bug to fix. Previous code was intentional. If you claim there is a bug, please explain what exactly is being fixed. > Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> Best regards, Krzysztof