On 8/19/2024 7:47 PM, James Prestwood wrote: > Hi Baochen, > > On 8/19/24 2:45 AM, Baochen Qiang wrote: >> >> On 8/14/2024 11:46 PM, James Prestwood wrote: >>> Hi Baochen, >>> >>> On 7/15/24 5:38 AM, James Prestwood wrote: >>>> Hi Baochen, >>>> >>>> I've compiled both changes and so far those messages are gone. >>>> >>>> Tested-By: James Prestwood <prestwoj@xxxxxxxxx> # on QCA6174 hw3.2 >>> I just noticed another one actually: >>> >>> invalid vht params rate 585 100kbps nss 1 mcs 4 >> Ah :( >> >> James, could you share some info about this? like hardware target, firmware version, AP model, and any specific steps to hit this. > > This is running with your fixes in this patch set, which did fix the majority of the "invalid vht params" messages, but then recently I noticed some others. > > The hardware: > > kernel: ath10k_pci 0000:02:00.0: qca6174 hw3.2 target 0x05030000 chip_id 0x00340aff sub 168c:3363 > kernel: ath10k_pci 0000:02:00.0: firmware ver WLAN.RM.4.4.1-00288- api 6 features wowlan,ignore-otp,mfp crc32 bf907c7c > > And its actually a few more than I thought: > > ath10k_pci 0000:02:00.0: invalid vht params rate 900 100kbps nss 3 mcs 4 > ath10k_pci 0000:02:00.0: invalid vht params rate 867 100kbps nss 2 mcs 6 > ath10k_pci 0000:02:00.0: invalid vht params rate 540 100kbps nss 3 mcs 3 > ath10k_pci 0000:02:00.0: invalid vht params rate 1500 100kbps nss 3 mcs 7 > > I unfortunately don't have a way to reproduce it. We just see this now somewhat rarely, e.g. 13 of the above in the last 3 days. I assume its just when the MCS/NSS changes and we hit a rate that isn't mapped right like the few you fixed. > Thank you for the info. will try to reproduce internally. > Thanks, > > James > > >> >>> Thanks, >>> >>> James >>> >>>> On 7/10/24 7:03 PM, Baochen Qiang wrote: >>>>> supported_vht_mcs_rate_nss1 and supported_vht_mcs_rate_nss2 in host do not >>>>> align with firmware's definitions, resulting in some warnings. Fix them. >>>>> >>>>> Baochen Qiang (2): >>>>> wifi: ath10k: fix invalid VHT parameters in >>>>> supported_vht_mcs_rate_nss1 >>>>> wifi: ath10k: fix invalid VHT parameters in >>>>> supported_vht_mcs_rate_nss2 >>>>> >>>>> drivers/net/wireless/ath/ath10k/mac.c | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> >>>>> base-commit: db1ce56e6e1d395dd42a3cd6332a871d9be59c45
