Search Linux Wireless

RE: [PATCH 16/20] wifi: rtw88: Add rtw8812a_table.{c,h}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ping-Ke Shih wrote:
> 
> > +
> > +const struct rtw_pwr_seq_cmd *card_enable_flow_8812a[] = {
> > +       trans_carddis_to_cardemu_8812a,
> > +       trans_cardemu_to_act_8812a,
> > +       NULL
> > +};
> > +
> > +const struct rtw_pwr_seq_cmd *enter_lps_flow_8812a[] = {
> > +       trans_act_to_lps_8812a,
> > +       NULL
> > +};
> > +
> > +const struct rtw_pwr_seq_cmd *card_disable_flow_8812a[] = {
> > +       trans_act_to_cardemu_8812a,
> > +       trans_cardemu_to_carddis_8812a,
> > +       NULL
> > +};
> > +
> 
> These three array should be 'const struct rtw_pwr_seq_cmd * const ...'.
> 
> I don't expect things in ".data" section.
> 
> $ objdump  -t rtw8812a_table.o | grep "\.data"
> 0000000000000000 g     O .data  0000000000000018 card_disable_flow_8812a
> 0000000000000020 g     O .data  0000000000000010 enter_lps_flow_8812a
> 0000000000000030 g     O .data  0000000000000018 card_enable_flow_8812a
> 

The existing chips have this style already, so we need additional one patch
to convert them into const first.






[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux