On Wed, Dec 03, 2008 at 09:20:46PM -0600, Larry Finger wrote: > Hin-Tak Leung wrote: > > --- On Thu, 4/12/08, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: > > > >> The current wireless statistics for the RTL8187 poorly > >> indicate the signal > >> strength and quality. With testing, I found that the AGC > >> value is inversely > >> correlated with the strength as in the RTL8187B. By > >> implementing a similar > >> calculation, much more code becomes common to the two > >> devices. > >> > >> Signed-off-by: Larry Finger > >> <Larry.Finger@xxxxxxxxxxxx> > >> Tested by: Martín Ernesto Barreyro > >> <barreyromartin@xxxxxxxxx> > >> --- > > Acked-by: Hin-Tak Leung <htl10@xxxxxxxxxxxxxxxxxxxxx> > > > > Acually eveything to do with "quality" can be moved out of the if/then. > > > > I mean these 3 lines: > > > > + if (quality > 100) > > + quality = 100; > > + .... > > + rx_status.qual = quality; > > > > You have removed "rx_status.qual = quality;" from the "then" part, but didn't put it back in the common portion afterwards? > > > > Also, what happened to "dev->max_signal = 65;" at the end? > > Thanks for the comments. I'll fix up the code and resubmit. > > The dev->max_signal is only needed if the IEEE80211_HW_SIGNAL_UNSPEC flag is > used. Once we switch to IEEE80211_HW_SIGNAL_DBM, then the maximum is known. I'm dropping this patch from my mailbox. Is a new version of this still coming? John -- John W. Linville Linux should be at the core linville@xxxxxxxxxxxxx of your literate lifestyle. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
