Search Linux Wireless

Re: [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 15, 2008 at 9:34 AM, Benoit Papillault
<benoit.papillault@xxxxxxx> wrote:
> From: Benoit PAPILLAULT <benoit.papillault@xxxxxxx>
>
> This patch is close to the original code except that
> ieee80211_get_hdrlen_from_skb() has been replaced by
> ath5k_hw_get_hdrlen_from_skb() which is specific to Atheros hardware. The same
> probably applies to ath9k as well.

I for one would rather still use ieee80211_get_hdrlen_from_skb(), and the
ath5k_pad_size() helper to calculate the pad size (=0 for small control
frames).  Was there any problem with the '> 24' check?

After all we're not computing the _header_ length, just the existence
of the pad (contents of which is meaningless so can't be counted as part
of the header).

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux