On 07/08/2024 17:51, Nemanov, Michael wrote:
> On 8/7/2024 10:06 AM, Krzysztof Kozlowski wrote:
>> On 06/08/2024 19:00, Michael Nemanov wrote:
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - ti,cc3300
>>> + - ti,cc3301
>>> + - ti,cc3350
>>> + - ti,cc3351
>>> +
>>> + reg:
>>> + description:
>>> + must be set to 2
>>
>> Then just const: 2 and drop free form text.
>>
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + description:
>>> + The out-of-band interrupt line.
>>> + Can be IRQ_TYPE_EDGE_RISING or IRQ_TYPE_LEVEL_HIGH.
>>> + If property is omitted, SDIO in-band IRQ will be used.
>>> + maxItems: 1
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/irq.h>
>>> +
>>> + // SDIO example:
>>
>> Drop, obvious.
>>
>>> + mmc {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + wifi@1{
>>
>> Missing space.
>>
>> Also, this does not match reg. Test your DTS with W=1 and FIX ALL warnings.
>>
>> Best regards,
>> Krzysztof
>>
>
> Will fix all above.
>
> I'm currently testing my .yaml with:
> make dt_binding_check DT_CHECKER_FLAGS=-m \
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml
>
> It reports no warnings. Adding W=1 doesn't seem to change anything. Am I
> missing something?
I said test your DTS, not bindings.
Best regards,
Krzysztof
