Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> wrote: > When the firmware interface layer was refactored it provided various > "get" and "set" functions. For the "get" in some cases a parameter > needed to be passed down to firmware as a key indicating what to > "get" turning the output parameter of the "get" function into an > input parameter as well. To accommodate this the "get" function blindly > copies the parameter which in some places resulted in an uninitialized > warnings from the compiler. These have been fixed by initializing the > input parameter in the past. Recently another batch of similar fixes > were submitted to address clang static checker warnings [1]. > > Proposing another solution by introducing a "query" variant which is used > when the (input) parameter is needed by firmware. The "get" variant will > only fill the (output) parameter with the result received from firmware > taking care of proper endianess conversion. > > [1] https://lore.kernel.org/all/20240702122450.2213833-1-suhui@xxxxxxxxxxxx/ > > Fixes: 81f5dcb80830 ("brcmfmac: refactor firmware interface layer.") > Reported-by: Su Hui <suhui@xxxxxxxxxxxx> > Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> Patch applied to wireless-next.git, thanks. c6002b6c05f3 wifi: brcmfmac: introducing fwil query functions -- https://patchwork.kernel.org/project/linux-wireless/patch/20240727185617.253210-1-arend.vanspriel@xxxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
