Search Linux Wireless

Re: [RFT] wifi: brcmfmac: Add optional lpo clock enable support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On August 2, 2024 7:28:51 PM Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> wrote:

On 8/2/24 01:34, Arend van Spriel wrote:
From: Jacobe Zang <jacobe.zang@xxxxxxxxxx>

WiFi modules often require 32kHz clock to function. Add support to
enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check
to the top of brcmf_of_probe

Co-developed-by: Ondrej Jirman <megi@xxxxxx>
Signed-off-by: Ondrej Jirman <megi@xxxxxx>
Signed-off-by: Jacobe Zang <jacobe.zang@xxxxxxxxxx>
[arend: handle -EPROBE_DEFER scenario]
Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>

This looks fine for a cold boot case, how about handling suspend/resume
where the clock might have been disabled, do we need to deal with an
"always-on" Device Tree property as well as whether the device is
enabled for wake-up or not?

Thanks, Florian

When the external LPO is disabled the chip will fallback on the internal (I think). So it is not an issue for wakeup scenario, but if the clock is not enabled upon resume we should deal with it. Could go in separate patch.

I can inquire about my assumption above.

Regards,
Arend







[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux