The Subject says RESEND but doesn't explain why you are resending. You probably meant v2, but again it needs an explanation. On Fri, Aug 02, 2024 at 12:27:40PM +0800, Ma Ke wrote: > This error path should return -EINVAL instead of success. Why do you feel that way? Have you tested it? What is the user visible effect of this bug? I slightly feel hypocritical because I have send lots of commit messages with exactly this commit message. The difference is that I only send really easy patches where it's obvious what the intent was. A normal kernel developer wouldn't need to leave their email client or view any outside information to see that my patch is correct. If a patch is not dead easy, I normally just report it. (Sometimes I report dead easy bugs as well because I am lazy and maybe it's the end of my work day or whatever). This patch on the other hand is more subtle and it's not clear why the continue statements changed into returns. regards, dan carpenter
