On 7/31/2024 8:45 AM, Jeff Johnson wrote: > On 7/30/2024 10:09 AM, Raj Kumar Bhagat wrote: >> + ret = ath12k_qmi_alloc_chunk(ab, chunk); > > seems like you need to test ret and return if non-zero here since currently if > you get a bad ret in one loop but you continue and get a good ret on the > remaining iterations then you'll end up returning success from this function. > > In other words, your refactoring doesn't correct handle that the original > "return -ENOMEM" would return from *this* function at this point I see you handle this in patch 2, but that portion of patch 2 should be moved to this patch
