On Tue, 30 Jul 2024 13:35:07 +0300, Kalle Valo wrote: > > syzbot report WARNING in plfxlc_mac_release, according to the context, > > there is not need assert for mac->lock. > > The commit message should explain _why_ the assert is not needed. > Otherwise it looks that you are randomly removing it to get rid of the > warning. mac->lock is used to protect mac data, but after calling plfxlc_mac_release(), there are two functions:ieee80211_unregister_hw() and ieee80211_free_hw(), there is no action to operate on mac data in these two functions, so mac->lock is not required. On the other hand, there is no holding action for mac->lock before calling plfxlc_mac_release. -- Edward
