Search Linux Wireless

Re: [RFC 2/3] mac80211: Make use of the new F_TX_NOACK and F_TX_NOSEQ Radiotap TX flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2008-12-12 at 23:43 +0100, Stefanik Gábor wrote:

> I tried, but for some reason setting IEEE80211_TX_CTL_NO_ACK directly
> in __ieee80211_parse_tx_radiotap resulted in an oops upon unloading
> the driver module.

Huh? That doesn't make sense. Do you have more information on that?

> Note that IEEE80211_TX_MON_NO_ACK is not equivalent to
> !(IEEE80211_TX_CTL_ASSIGN_SEQ), as it also disables mac80211's built
> in sequence numbering.

Ah. But there's precedence for just doing

if (unlikely(!(info->flags & ASSIGN_SEQ)))
	return;

in the handler that assigns the seq, and I prefer that over adding a new
flag.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux