On 7/17/2024 7:22 PM, Lingbo Kong wrote: > > > On 2024/7/18 5:44, Jeff Johnson wrote: >> On 7/17/2024 1:36 PM, kernel test robot wrote: >>> Hi Lingbo, >>> >>> kernel test robot noticed the following build errors: >>> >>> [auto build test ERROR on db1ce56e6e1d395dd42a3cd6332a871d9be59c45] >>> >>> url: https://github.com/intel-lab-lkp/linux/commits/Lingbo-Kong/wifi-ath12k-Add-support-for-obtaining-the-buffer-type-ACPI-function-bitmap/20240717-211701 >>> base: db1ce56e6e1d395dd42a3cd6332a871d9be59c45 >>> patch link: https://lore.kernel.org/r/20240717111023.78798-3-quic_lingbok%40quicinc.com >>> patch subject: [PATCH 2/4] wifi: ath12k: Add Support for enabling or disabling specific features based on ACPI bitflag >>> config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240718/202407180403.SFqsPj0v-lkp@xxxxxxxxx/config) >>> compiler: alpha-linux-gcc (GCC) 13.3.0 >>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240718/202407180403.SFqsPj0v-lkp@xxxxxxxxx/reproduce) >>> >>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>> the same patch/commit), kindly add following tags >>> | Reported-by: kernel test robot <lkp@xxxxxxxxx> >>> | Closes: https://lore.kernel.org/oe-kbuild-all/202407180403.SFqsPj0v-lkp@xxxxxxxxx/ >>> >>> All errors (new ones prefixed by >>): >>> >>> drivers/net/wireless/ath/ath12k/core.c: In function 'ath12k_core_rfkill_config': >>>>> drivers/net/wireless/ath/ath12k/core.c:33:15: error: 'struct ath12k_base' has no member named 'acpi' >>> 33 | if (ab->acpi.acpi_disable_rfkill) >>> | ^~ >>> -- >>> drivers/net/wireless/ath/ath12k/mac.c: In function 'ath12k_mac_copy_eht_cap': >>>>> drivers/net/wireless/ath/ath12k/mac.c:5488:19: error: 'struct ath12k_base' has no member named 'acpi' >>> 5488 | ar->ab->acpi.acpi_disable_11be) >>> | ^~ >>> >> >> Lingbo, >> looks like you need to have support functions in acpi.c with suitable stub >> functions in acpi.h for cases where CONFIG_ACPI is disabled. >> >> You cannot directly access ab->acpi outside acpi.c >> >> Nice catch kernel test robot. Wish I had the resources to run every patch >> through a large number of build configurations! >> >> /jeff > > thanks a lot! jeff, > > i'll change it in next version. > When i checked these codes using ath12k-check and smatch, these issues > did not appear:( > Out of curiosity, how can i set up a similar kernel test boot locally? > i can avoid issues like this when sending public reviews. These aren't boot issues, they are build issues. The only way to recreate is to build for all supported architectures. Note that this was found when building config: alpha-allyesconfig, compiler: alpha-linux-gcc (GCC) 13.3.0, so for ARCH=alpha. So you can recreated by downloading the alpha-linux-gcc toolchain from crosstools and building the allyesconfig with ARCH=alpha. /jeff
