On Mon, Jul 8, 2024, at 21:31, Kees Cook wrote: > On Mon, Jul 08, 2024 at 06:51:52PM +0300, Kalle Valo wrote: > > I suspect this won't be the only place in the kernel where -Wrestrict > will give weird results with GCC 11, and there are still plenty of folks > using GCC 11. I think the best option would probably be to version-check > GCC to gate the addition of -Wrestrict. > > Arnd, what do you think? This looks like a more extreme version of > commit f9fc1ec28bae ("crypto: drivers - avoid memcpy size warning") The f9fc1ec28bae patch was the other way around, it showed up in new compilers but not old ones. I don't think I've seen more gcc-11 -Wrestrict warnings during testing, but I'm currently not set up to do a thorough search. If it's the only one, then Kalle's suggested workaround is probably best, but if there are additional warnings on gcc-11, making the warning depend newer compilers is also fine. I just don't want to give up the warning for new compilers altogether. Arnd