On Wed, 2024-07-03 at 20:16 +0200, Christian Lamparter wrote:
> On 7/2/24 12:41 PM, Alexander Wetzel wrote:
> > The commit 5c38bedac16a ("wifi: iwlwifi: mvm: unify and fix interface
> > combinations") breaks mvm hard. wlan interface can't be created and even
> > rmmod fails.
> >
> > On driver load I get:
> >
> > WARNING: CPU: 5 PID: 1358 at net/wireless/core.c:689 wiphy_register+0x8ee/0x920 [cfg80211]
> ran into the same issue. Debugging revealed that the " - 1" is the problem
> because wiphy_verify_combinations checks if the specified limits in n_limits.max
> adds up to at least max_interfaces (=3), which isn't true anymore with the
> " - 1" as the ieee80211_iface_limit with NL80211_IFTYPE_P2P_DEVICE is missing.
>
> Not sure, if this needs fixing in cfg80211 or iwlwifi. But I can confirm that this
> patch "works" (not sure if it's correct/intended though).
>
I sent the exact same patch yesterday :)
https://lore.kernel.org/20240702130001.8c871a3f0b5a.I08a6542f52f63c5bd66bf3feb09e1998ce7c60e5@changeid/
We have a version that has another array entry for NAN support and then
subtracts 1 here to add it conditionally again later etc., and this got
mixed up when sending out the patch.
johannes
