On Mon, Jul 1, 2024 at 2:58 PM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Mon, 2024-07-01 at 14:28 -0700, Rosen Penev wrote: > > On Mon, Jul 1, 2024 at 3:01 AM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > > > > > On Fri, 2024-06-28 at 15:32 -0700, Rosen Penev wrote: > > > > __SANE_USERSPACE_TYPES__ needs to be defined to get consistent 64-bit > > > > type defines and to fix -Wformat warnings. > > > > > > > > > > How does this even work? Pretty much every file I checked in iw includes > > > iw.h _last_ (or close to it), after netlink, nl80211.h etc., so ...? > > > Doesn't really seem like it would have any effect? > > I only tested compilation of iw itself, not of any project that uses it. > > Hm? It's iw itself only anyway? But where did you see warnings/errors, > and why did they go away when this shouldn't have really done anything? The whole codebase. They go away because if the define is found before any header inclusion, __u64 gets defined to unsigned long long. Note that the header after the define include linux headers. The impacted architectures can be found in the kernel with git grep SANE_USERSPACE arch > > johannes > >
