On Sun, 2024-06-30 at 09:50 +0200, Felix Fietkau wrote: > > + * @get_radio_mask: get bitmask of radios in use I think you should document the (locking) context here - you seem to assume (later in mac80211) that this is only called in RCU critical section, but I'm not really sure why? (IOW, I'm not sure that's even correct?) Also I suppose could use a note that this may be called within the context of cfg80211_iter_combinations() so need to be careful about locking with that, I think. I'm not sure it's *only* called in that context? johannes