On Thu, 2024-06-27 at 09:47 +0530, Aditya Kumar Singh wrote: > > Not sure I buy that argument though, it feels wrong. Clearly you should > > be able to stop this from even cfg80211, it tracks whether radar > > detection is running, so whenever the link is removed, you can also stop > > it there? Doing it on free seems much too late. > > > > Actually if cfg80211_remove_link() is called, then it is aborted during > stop_ap handler. So that path is fine only. This was done in situations > where properly interface is not brought down or abruptly brought down. > For example AP is started and then directly iw wlanX del is issued. Still cfg80211 should clean up the link and call stop_ap() etc. If that's broken we need to fix it. > Ideally the normal deinit flow should have taken care but just in case > if still somehow by passes it then ultimately while freeing the links it > will be aborted. May be should I rephrase the commit message? I think we need to fix the cases where it doesn't clean up properly instead. johannes
