On 6/27/2024 10:43 AM, Kalle Valo wrote: > Aaradhana Sahu <quic_aarasahu@xxxxxxxxxxx> wrote: > >> Add support to process factory test mode commands(FTM) for calibration. >> By default firmware start with MISSION mode and to process the FTM commands >> firmware needs to be restarted in FTM mode using module parameter ftm_mode. >> The pre-request is all the radios should be down before starting the test. >> >> All ath12k test mode interface related commands specified in enum >> ath_tm_cmd. >> >> When start command ATH_TM_CMD_TESTMODE_START is received, ar state >> is set to test Mode and FTM daemon sends test mode command to wifi >> driver via cfg80211. Wifi driver sends these command to firmware as >> wmi events. If it is segmented commands it will be broken down into >> multiple segments and encoded with TLV header else it is sent to >> firmware as it is. >> >> Firmware response via UTF events, wifi driver creates skb and send >> to cfg80211, cfg80211 sends firmware response to FTM daemon via >> netlink message. >> >> Command to boot in ftm mode >> insmod ath12k ftm_mode=1 >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00210-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Aaradhana Sahu <quic_aarasahu@xxxxxxxxxxx> >> Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> >> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> > > Now that the wow patchset was applied I saw a new warning: > > drivers/net/wireless/ath/ath12k/wow.c: In function 'ath12k_wow_op_resume': > drivers/net/wireless/ath/ath12k/wow.c:982:17: warning: enumeration value 'ATH12K_HW_STATE_TM' not handled in switch [-Wswitch] > > I fixed it adding the new state to ath12k_wow_op_resume(), please check: > > https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=882f310572b27564412e1d6158d1e9709861b7a7 > LGTM, thanks!
