Search Linux Wireless

[PATCH 26/43] wifi: nxpwifi: add sdio.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/27/2024 6:37 AM, David Lin wrote:

On 6/21/2024 10:51 AM, David Lin wrote:
...
+
+/* This function unregisters the SDIO device.
+ *
+ * The SDIO IRQ is released, the function is disabled and driver
+ * data is set to null.
+ */
+static void
+nxpwifi_unregister_dev(struct nxpwifi_adapter *adapter) {
+     struct sdio_mmc_card *card = adapter->card;
+
+     if (adapter->card) {
+             card->adapter = NULL;
+             sdio_claim_host(card->func);
+             sdio_disable_func(card->func);
+             sdio_release_host(card->func);
+     }
+}

Missing call to sdio_release_irq() ?

Michael.

sdio_release_irq() is called by nxpwifi_sdio_disable_host_int().

David

Right, I see you calling it from nxpwifi_uninit_sw(). Maybe just align the comment then.

Michael.




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux