Search Linux Wireless

Re: [PATCH v2 8/9] wifi: mac80211: handle ieee80211_radar_detected() for MLO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2024-06-26 at 10:22 +0530, Aditya Kumar Singh wrote:
> 
> Hence, in order to support DFS with MLO, do the following changes -
>   * Add channel pointer as an argument to the function
>     ieee80211_radar_detected(). During MLO, drivers would have to pass on
>     which channel radar is detected.

Makes sense, maybe?

>   * In order to pass on this channel information to the radar detected
>     worker later on, introduce a linked list 'radar_info' in the structure
>     local.
>   * When driver calls radar detected, a node is created and added to this
>     list and work is scheduled. The work handler takes care to process each
>     node and take further action.

Not sure I like that so much, it adds book-keeping and all kinds of
extra things.

Couldn't we just have a flag in the channel context or so - there must
be one, after all? And perhaps pass the chanctx from the driver instead
of the channel?

Actually, we're already having to do a channel/chanctx lookup in
ieee80211_dfs_radar_detected_work() so it seems pretty weird to add more
complex logic to it...

Please consider just passing the chanctx, and then we can set a flag
there, and not have any of this.

johannes






[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux