On Wed, 2024-06-26 at 10:22 +0530, Aditya Kumar Singh wrote: > > Since currently, link ID is not known at all places, use default value of > 0 for now. If link ID is available, use that instead is such places. I think you're playing with fire a bit this way ... now you can e.g. actually start radar detection but it'll use link 0 in nl80211_start_radar_detection(), but then start an AP and actually check that you're not doing radar detection on _that link_ in nl80211_start_ap(), all while mac80211 (only 'driver' possibly supporting any of this right now) still hasn't actually been updated to do anything per link ... Now we could argue that it doesn't really matter since hwsim is the only driver right now (though iwlwifi will enable MLO soon now). But also, it seems unnecessary? Why not add the link ID to APIs and mac80211 first, and then actually switch over to using it? I may be wrong, but naively I'd think it's just a question of ordering and/or recombining the patches differently, more or less? Certainly you could have patch 5 first, and just ignore the link ID in cfg80211 for now, and switch over to actually being able to start CAC etc. on links other than 0 (and checking against the correct link) as the last patch? johannes
