Hi Felix,
Thank you for making the changes. They look correct to me. I
appreciate your help with this!
Sean
On Mon, Jun 24, 2024 at 12:03 PM Felix Fietkau <nbd@xxxxxxxx> wrote:
>
> On 24.06.24 19:44, Felix Fietkau wrote:
> > On 13.06.24 05:02, sean.wang@xxxxxxxxxx wrote:
> >> From: Sean Wang <sean.wang@xxxxxxxxxxxx>
> >>
> >> Extend mt76_connac_mcu_sta_basic_tlv with the per-link STA configuration.
> >>
> >> The patch we created is a prerequisite to enable the MLO function in the
> >> driver. It is purely a refactoring patch so the functionality should
> >> remain unchanged.
> >>
> >> Co-developed-by: Ming Yen Hsieh <mingyen.hsieh@xxxxxxxxxxxx>
> >> Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@xxxxxxxxxxxx>
> >> Co-developed-by: Deren Wu <deren.wu@xxxxxxxxxxxx>
> >> Signed-off-by: Deren Wu <deren.wu@xxxxxxxxxxxx>
> >> Signed-off-by: Sean Wang <sean.wang@xxxxxxxxxxxx>
> >
> > This patch is broken on non-mt762x drivers, because the functions that
> > call mt76_connac_mcu_sta_basic_tlv may be called with sta == NULL.
> >
> > I've seen it crash on mt7996 because of that, but mt7915 and mt7615 are
> > likely equally affected.
>
> I've pushed a fixed version to my tree. Please check if it looks correct
> to you.
>
> Thanks,
>
> - Felix
>
