On Thursday 11 December 2008 19:14:47 you wrote: > > Okay... I have included a casting to s8 into cfg.c so everyone is > > warned... the original signal field in the sta_info struct is an int, but > > this structure is used by the drivers so I don't want to touch it. > > Right, not sure what happens when it's not in dBm anyway. > > Ok. I noticed a few more things, sorry: no problem... I want to get the bugs out of the patch, not to get it "in" as soon as possible. > > + * enum nl80211_rate_info - bitrate information > > + * > > + * These attribute types are used with %NL80211_STA_INFO_TXRATE > > + * when getting information about the bitrate of a station. > > + * > > + * @__NL80211_RATE_INFO_INVALID: attribute number 0 is reserved > > + * @NL80211_RATE_INFO_BITRATE: total bitrate (u16, 100kbit/s) > > + * @NL80211_RATE_INFO_MCS: mcs index for 802.11n (u8) > > + * @NL80211_RATE_INFO_40_MHZ_WIDTH: 40 Mhz dualchannel bitrate > > + * @NL80211_RATE_INFO_SHORT_GI: 400ns guard interval > > This needs documentation for __...after_last and ..._max too, I think, > or kernel-doc will complain, and then I get email on the next daily git > update and complain ;) Is there a script to check for mistakes like this ? I used checkpatch.pl and it did not complain... > Other than that, > > Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > so feel free to add that into the patch when you resend. I will... together with the iw patch. Henning
Attachment:
signature.asc
Description: This is a digitally signed message part.
