On Fri, Jun 21, 2024 at 12:52 AM David Lin <yu-hao.lin@xxxxxxx> wrote: > This driver is a derivative of existing Mwifiex [1] and based on similar > full-MAC architecture [2]. For the record, mwifiex is a fairly awful driver. For one, its locking schemes are generally unhelpful or nonexistent, and sometimes placebo-like (as in, they look like they are protecting certain data, but they do a very poor job of it). So I'm not sure this is a promising start. It was just yesterday, in fact, that I was telling a colleague that if mwifiex was proposed for inclusion in mainline today, I would reject it. Also, I'm far from interested in reviewing a new driver here. My only interest in mwifiex is in making sure existing hardware (especially those used on Chromebooks) doesn't get significantly worse. That interest doesn't extend to "nxpwifi". I just want to be up-front about it, and that you might as well drop me from the CC list. (Of course, that's not a requirement. I can ignore email too.) Brian
