On 6/19/2024 7:43 PM, Kalle Valo wrote: > Ramya Gnanasekar <quic_rgnanase@xxxxxxxxxxx> writes: > >> From: Lingbo Kong <quic_lingbok@xxxxxxxxxxx> >> >> Pdev id from mac phy capabilities will be sent as a part of >> HTT/WMI command to firmware. This causes issue with single pdev >> devices where firmware does not respond to the WMI/HTT request >> sent from host. > > But WCN7850 already works so I'm not really understanding the bug > description. Can you elaborate, please? pdev id from mac capabilities sent as a part of HTT stats request or WMI control path stats request was not expected by WCN7850 and hence fails to send the stats response. > >> @@ -81,5 +81,8 @@ int ath12k_mac_rfkill_config(struct ath12k *ar); >> int ath12k_mac_wait_tx_complete(struct ath12k *ar); >> void ath12k_mac_handle_beacon(struct ath12k *ar, struct sk_buff *skb); >> void ath12k_mac_handle_beacon_miss(struct ath12k *ar, u32 vdev_id); >> +u8 ath12k_mac_get_target_pdev_id(struct ath12k *ar); >> +u8 ath12k_mac_get_target_pdev_id_from_vif(struct ath12k_vif *arvif); >> +struct ath12k_vif *ath12k_mac_get_vif_up(struct ath12k *ar); > > AFAICS ath12k_mac_get_target_pdev_id_from_vif() and > ath12k_mac_get_vif_up() can be static, no need to add them to mac.h. Ah! Sure Kalle. I will take care. > > So we are left with ath12k_mac_get_target_pdev_id() but I don't see it > called anywhere. Isn't that dead code we are adding? The wrapper is used by upcoming HTT stats and WMI control path stats support. Initially this change was added in the HTT stats infrastructure support series. Since WMI control path stats also depends on this patch, to eliminate the another patch series dependency, I pulled out this patch from HTT stats series. This wrapper will be used by below changes: HTT stats: https://lore.kernel.org/linux-wireless/20240614063404.2659089-1-quic_rgnanase@xxxxxxxxxxx/T/ WMI control path stats: https://patchwork.kernel.org/project/linux-wireless/patch/20240529180920.1472003-1-quic_rgnanase@xxxxxxxxxxx/ WMI control path stats has to be rebased on this current patch. Since it is deferred, I refrained from sending v2. >
