Marcin Ślusarz <marcin.slusarz@xxxxxxxxx> wrote:
>
> High queue is not functioning, for some reason.
> Broken by 076f786a0ae14a81f40314b96a2d815e264bc213
Pointing out 076f786a0ae1 ("wifi: rtw88: Fix AP mode incorrect DTIM behavior")
would be clearer. Please also mentioned the chip you are using.
>
> Signed-off-by: Marcin Ślusarz <mslusarz@xxxxxxxxx>
> Cc: Po-Hao Huang <phhuang@xxxxxxxxxxx>
> Cc: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>
> ---
> drivers/net/wireless/realtek/rtw88/usb.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c
> index c25fd4b193a7..aacc5a105b15 100644
> --- a/drivers/net/wireless/realtek/rtw88/usb.c
> +++ b/drivers/net/wireless/realtek/rtw88/usb.c
> @@ -492,9 +492,6 @@ static u8 rtw_usb_tx_queue_mapping_to_qsel(struct sk_buff *skb)
>
> if (unlikely(ieee80211_is_mgmt(fc) || ieee80211_is_ctl(fc)))
> qsel = TX_DESC_QSEL_MGMT;
> - else if (is_broadcast_ether_addr(hdr->addr1) ||
> - is_multicast_ether_addr(hdr->addr1))
> - qsel = TX_DESC_QSEL_HIGH;
I think broadcast/multicast packets should go via HIGH queue is correct, but
somehow registers aren't configured correctly. Bernie (you have CC'ed) will
help to check registers.
> else if (skb_get_queue_mapping(skb) <= IEEE80211_AC_BK)
> qsel = skb->priority;
> else
> --
> 2.25.1
