On Wed, 2024-06-12 at 18:12 +0800, quic_zijuhu wrote: > On 6/12/2024 4:15 PM, Johannes Berg wrote: > > > > > > use pr_err() instead of WARN() > > > for this error case handling. > > > > I don't see anything wrong with the WARN here, it's the user/driver > > calling it completely incorrectly. > > > the function is a kernel API Sure. > and it is handing invalid user input. No. johannes