Search Linux Wireless

Re: [RFC]: atk5k: fix FCS corruption for ACKs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 10, 2008 at 8:43 AM, Sujith <m.sujith@xxxxxxxxx> wrote:
>>    957          /* remove FCS before passing up to protocol stack */
>>    958          skb_trim(skb, (skb->len - FCS_LEN));
>>
>
> I remember removing this piece of code...

Hmm, you're right.  I must've been looking at 2.6.27.  Sorry for the noise.

The padding still gets removed regardless of whether there is a payload;
does that truncate the FCS for ACK/CTS frames on ath9k?

>>    952          if (hdrlen & 3) {
>>    953                  padsize = hdrlen % 4;

While we're at it, (for ath5k also) -- hdrlen % 4 can just be hdrlen & 3
again.

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux