On Fri, Jun 07, 2024 at 03:20:44AM -0700, Breno Leitao wrote: > Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is > configured") moved the callback to dev_get_tstats64() to net core, so, > unless the driver is doing some custom stats collection, it does not > need to set .ndo_get_stats64. > > Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it > doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 > function pointer. > > In this driver specifically, .ndo_get_stats64 basically points to > dev_fetch_sw_netstats(). Now it will point to dev_get_tstats64(), which > calls netdev_stats_to_stats64() and dev_fetch_sw_netstats(). > netdev_stats_to_stats64() seems irrelevant for this driver. > > Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>