On Wed, 2008-12-10 at 08:24 -0500, Bob Copeland wrote:
> It seems very plausible to me. Though, why doesn't ath9k also have this
> problem? Luis, it looks like in that case ath9k could trim two extra
> bytes if ath9k hw behaves the same.
>
> main.c:
>
> 951 /* see if any padding is done by the hw and remove it */
> 952 if (hdrlen & 3) {
> 953 padsize = hdrlen % 4;
> 954 memmove(skb->data + padsize, skb->data, hdrlen);
> 955 skb_pull(skb, padsize);
> 956 }
>
> 957 /* remove FCS before passing up to protocol stack */
> 958 skb_trim(skb, (skb->len - FCS_LEN));
It also shouldn't remove the FCS, sometimes you want to see that on
wireshark and mac80211 handles removing the FCS itself just fine, just
set the HW flag.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
