Search Linux Wireless

Re: [PATCH] b43legacy: Fix sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 10 December 2008 06:35:41 Larry Finger wrote:
>   CHECK   drivers/net/wireless/b43legacy/debugfs.c
> drivers/net/wireless/b43legacy/debugfs.c:243:9: warning: memset with byte count of 131072

I know about this error and I think it's a damn stupid error.
There is a reason why the value was so high in b43. I don't know about b43legacy.
Did you check if all callbacks still work properly?

> Index: wireless-testing/drivers/net/wireless/b43legacy/debugfs.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43legacy/debugfs.c
> +++ wireless-testing/drivers/net/wireless/b43legacy/debugfs.c
> @@ -211,7 +211,7 @@ static ssize_t b43legacy_debugfs_read(st
>  	struct b43legacy_dfs_file *dfile;
>  	ssize_t uninitialized_var(ret);
>  	char *buf;
> -	const size_t bufsize = 1024 * 128;
> +	const size_t bufsize = 1024 * 16; /* 16 KiB buffer */
>  	const size_t buforder = get_order(bufsize);
>  	int err = 0;

-- 
Greetings, Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux