On Thu, Jun 6, 2024 at 3:30 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Bartosz Golaszewski <brgl@xxxxxxxx> writes: > > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > > Add a PCI compatible for the ATH11K module on QCA6390 and describe the > > power inputs from the PMU that it consumes. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > [...] > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: pci17cb,1101 > > + then: > > + required: > > + - vddrfacmn-supply > > + - vddaon-supply > > + - vddwlcx-supply > > + - vddwlmx-supply > > + - vddrfa0p8-supply > > + - vddrfa1p2-supply > > + - vddrfa1p7-supply > > + - vddpcie0p9-supply > > + - vddpcie1p8-supply > > Not sure if we discussed this before, but based on this I understand > that there can't be an DT entry for device pci17cb,1101 without all the > supply properties? But there are QCA6390 devices with PCI id 17cb:1101 > which do not need these supplies and already work. For example, my Dell > XPS 13 x86 laptop is one. Or anyone who manually installs QCA6390 board > to their PCI slot and some of them might want to use DT, for example > setting qcom,ath11k-calibration-variant. > > This is not a blocker for me, just making sure that we are not breaking > any existing setups. > If they are already powered up without the need for the PCI pwrctl driver to do it, then they will work alright. Bindings don't affect functionality. But if you have a QCA6390 then you have its PMU too and the bindings model the real-world hardware. IOW: your laptop should be alright but the supplies are really there which warrants adding them to the bindings. Bart > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
