> I feel this type of changes fall into the category of bike-shedding. People I have two motivations for this change: One may be bike-shedding, yet "if (!timeout) return -ETIMEDOUT" looks stupid to me. > should know how wait_event_timeout() works and then a variable name does not > really matter. And for a new developer, I am quite sure the change will help to understand how wait_event-family() works. Especially given that wait_event_interruptible() returns 0 if condition is true and wait_event_interruptible_timeout() returns 0 if condition is false. > > Fix to the proper variable type 'long' while here. > > But it may have useful side-effects to go over the code with fresh look. :) > Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> Thank you!