Search Linux Wireless

Re: [PATCH 1/2] wifi: rtw88: use RTW_FLAG_RUNNING for deciding whether to enter/leave IPS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



wt., 28 maj 2024 o 05:56 Ping-Ke Shih <pkshih@xxxxxxxxxxx> napisał(a):
>
> Marcin Ślusarz <marcin.slusarz@xxxxxxxxx> wrote:
> > From: Marcin Ślusarz <mslusarz@xxxxxxxxx>
> >
> > Needed by the next patch that disables power off operation for one chip.
> >
> > Signed-off-by: Marcin Ślusarz <mslusarz@xxxxxxxxx>
> > Cc: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> > Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> > Cc: Kalle Valo <kvalo@xxxxxxxxxx>
> > Cc: linux-wireless@xxxxxxxxxxxxxxx
> > ---
> >  drivers/net/wireless/realtek/rtw88/ps.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtw88/ps.c b/drivers/net/wireless/realtek/rtw88/ps.c
> > index add5a20b8432..f9fbc9b3174b 100644
> > --- a/drivers/net/wireless/realtek/rtw88/ps.c
> > +++ b/drivers/net/wireless/realtek/rtw88/ps.c
> > @@ -26,7 +26,7 @@ static int rtw_ips_pwr_up(struct rtw_dev *rtwdev)
> >
> >  int rtw_enter_ips(struct rtw_dev *rtwdev)
> >  {
> > -       if (!test_bit(RTW_FLAG_POWERON, rtwdev->flags))
> > +       if (!test_bit(RTW_FLAG_RUNNING, rtwdev->flags))
>
> RTW_FLAG_POWERON is to maintain power state (i.e. ips) of WiFi card, and
> prevent entering/leaving IPS twice suddenly. Changing this is confused to me.

I explained it in the other thread as a reply to Bitterblue.





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux