Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Tue, 2024-05-28 at 02:39 +0000, Ping-Ke Shih wrote: > > One thing is that should we honor the values set by user space? > > > > If user space has not set, driver wants to control this value by itself > > according to AP/IBSS/station modes. > > If user space has set, driver fully follows the value from user space. > > Is above the behavior you want? > > Honestly, is it? I think most drivers these days probably ignore the > values from userspace for lesser reasons (e.g. iwlwifi always has a > firmware-internal limit of 16 IIRC.) > > This API also comes from the dawn of wireless in Linux, and was just > ported from wireless extensions to nl80211. So I wouldn't feel too bad > about simply ignoring it either. Agree. My thought was limited to have the same behavior as rtlwifi was. Ignoring handle of IEEE80211_CONF_CHANGE_RETRY_LIMITS would be simpler. Ping-Ke
