P Praneesh <quic_ppranees@xxxxxxxxxxx> wrote: > For fragmented packets, ath12k reassembles each fragment as a normal > packet and then reinjects it into HW ring. In this case, the DMA > direction should be DMA_TO_DEVICE, not DMA_FROM_DEVICE. Otherwise, > an invalid payload may be reinjected into the HW and > subsequently delivered to the host. > > Given that arbitrary memory can be allocated to the skb buffer, > knowledge about the data contained in the reinjected buffer is lacking. > Consequently, there’s a risk of private information being leaked. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00209-QCAHKSWPL_SILICONZ-1 > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Co-developed-by: Baochen Qiang <quic_bqiang@xxxxxxxxxxx> > Signed-off-by: Baochen Qiang <quic_bqiang@xxxxxxxxxxx> > Signed-off-by: P Praneesh <quic_ppranees@xxxxxxxxxxx> > Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> 3 patches applied to ath-next branch of ath.git, thanks. 33322e3ef074 wifi: ath12k: change DMA direction while mapping reinjected packets 073f9f249eec wifi: ath12k: fix invalid memory access while processing fragmented packets a57ab7cced45 wifi: ath12k: fix firmware crash during reo reinject -- https://patchwork.kernel.org/project/linux-wireless/patch/20240520070045.631029-2-quic_ppranees@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches