Hi, Subject "wifi: rtw89: chan: Use swap() instead of open coding it" is too common. If more than one patch does similar thing, we can't know the change from subject. It would be better to mention "swap sub_entity". Others are good to me. On Fri, 2024-05-24 at 15:58 +0800, Jiapeng Chong wrote: > > Swap is a function interface that provides exchange function. To avoid > code duplication, we can use swap function. > > ./drivers/net/wireless/realtek/rtw89/chan.c:2336:32-33: WARNING opportunity for swap(). > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9174 > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> >
