On Tue May 21, 2024 at 10:04 AM CEST, Kalle Valo wrote: > Carl Huang <quic_cjhuang@xxxxxxxxxxx> wrote: > > > WCN6750 firmware crashes because of num_vdevs changed from 4 to 17 > > in ath11k_init_wmi_config_qca6390() as the ab->hw_params.num_vdevs > > is 17. This is caused by commit f019f4dff2e4("wifi: ath11k: support > > 2 station interfaces") which assigns ab->hw_params.num_vdevs directly > > to config->num_vdevs in ath11k_init_wmi_config_qca6390(), therefore > > WCN6750 firmware crashes as it can't support such a big num_vdevs. > > > > Fix it by assign 3 to num_vdevs in hw_params for WCN6750 as 3 is > > sufficient too. > > > > Fixes: f019f4dff2e4 ("wifi: ath11k: support 2 station interfaces") > > Reported-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx> > > Closes: https://lore.kernel.org/r/D15TIIDIIESY.D1EKKJLZINMA@xxxxxxxxxxxxx/ > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-01371-QCAMSLSWPLZ-1 > > > > Signed-off-by: Carl Huang <quic_cjhuang@xxxxxxxxxxx> > > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> > > This patch should go to v5.10 but I'll wait for Luca to test this first. No > rush with testing, this is just a status update. Hi Kalle & Carl, Thanks for adding me to CC, I didn't receive the original patch (@Carl maybe check your email setup why I didn't get that one?). I've reverted the previous patch "fix WCN6750 firmware crash" in my branch and applied this one and everything still looks fine. Thanks! Tested-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx> Regards Luca