Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > If ath10k_snoc is built-in, while Qualcomm remoteprocs are built as > modules, compilation fails with: > > /usr/bin/aarch64-linux-gnu-ld: drivers/net/wireless/ath/ath10k/snoc.o: in function `ath10k_modem_init': > drivers/net/wireless/ath/ath10k/snoc.c:1534: undefined reference to `qcom_register_ssr_notifier' > /usr/bin/aarch64-linux-gnu-ld: drivers/net/wireless/ath/ath10k/snoc.o: in function `ath10k_modem_deinit': > drivers/net/wireless/ath/ath10k/snoc.c:1551: undefined reference to `qcom_unregister_ssr_notifier' > > Add corresponding dependency to ATH10K_SNOC Kconfig entry so that it's > built as module if QCOM_RPROC_COMMON is built as module too. > > Fixes: 747ff7d3d742 ("ath10k: Don't always treat modem stop events as crashes") > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> Patch applied to ath-current branch of ath.git, thanks. 21ae74e1bf18 wifi: ath10k: fix QCOM_RPROC_COMMON dependency -- https://patchwork.kernel.org/project/linux-wireless/patch/20240511-ath10k-snoc-dep-v1-1-9666e3af5c27@xxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches