On Fri, 2024-05-17 at 09:13 -0500, Larry Finger wrote: > > On 5/16/24 7:55 PM, Ping-Ke Shih wrote: > > I would like to compare the firmware locally, so apply the patch by > > $ pwclient git-am 13666343 > > > > Unfortunately the size of rtw88/rtw8821a_fw.bin is 0 in my side: > > WHENCE | 1 + > > rtw88/README | 3 +++ > > rtw88/rtw8821a_fw.bin | 0 > > 3 files changed, 4 insertions(+) > > > > Not sure what happens. Could you try it in your side? > > Ping-Ke, > > It took me a while to get pwclient running here, but when I did it truncated > the firmware file to length 0. If I apply the E-mail file that I sent, it comes > out OK, I don't know why, and just wonder if maintainers might encounter the same problem I met. I tried to add your attachment firmware to the patch locally and generate and compare local patch with your E-mail file -- no obvious difference, only the order of WHENCE and README. Then I tried to change the order of your E-mail file, and finally it works in my side. If you want me to assist sending a pull-request to prevent back and forth just because of above problem, please let me know. By the way, my mail server noticed me failed to deliver to "linux-firmware@xxxxxxxxxxxxxxx" Instead, README.md says firmware should be sent to "linux-firmware@xxxxxxxxxx" > > Attached is the firmware file that I sent. > I have confirmed attached firmware is the same as released one, and also the same as the one you sent. Ping-Ke
