Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > On 5/10/2024 8:09 PM, Lingbo Kong wrote: > > Your subject doesn't quite make sense. > > Perhaps something like: fix ack signal strength calculation > >> Currently, the calculation of ack signal strength is incorrect. >> >> This is because before calculating the ack signal strength, ath12k need >> to determine whether the hardware and firmware support db2dbm, if the > > please split this run-on sentence, s/, if/. If/ > >> hardware and firmware support db2dbm, do not need to add noise floor, >> otherwise, need to add noise floor. >> >> Besides, the value of ack_rssi passed by firmware to ath12k should be a >> signed number, so change its type to s8. >> >> This patch affects QCN9274 and WCN7850 because they have the same issue. >> >> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Lingbo Kong <quic_lingbok@xxxxxxxxxxx> > > Code LGTM & Kalle can fix my comments in pending so don't respin unless there > are additional comments. Fixed Jeff's comments. I also removed both db2dbm variables, I felt that they were not necessary. Please check: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=c7b6d4df1ac8427ac758f35b7c1aa641fa8df75f -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
