Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > On 5/10/2024 12:04 AM, Nithyanantham Paramasivam wrote: > >> We observe intermittent ping failures from the access point (AP) to >> station (STA) in any mode(AP-STA or Mesh) configured. Specifically, >> the transmission completion status is not received at Tx completion >> ring id-4(WBM2SW ring4) for the packets transmitted via TCL DATA >> ring id-3. This prevents freeing up Tx descriptors and leads >> to buffer exhaustion. >> >> Currently, during initialization of the WBM2SW ring, we are directly >> mapping the ring number to the ring mask to obtain the ring mask >> group index. This approach is causing setup failures for WBM2SW >> ring-4. Similarly, during runtime, when receiving incoming >> transmission completion status, the validation of the ring number by >> mapping the interrupted ring mask. This is resulting in >> validation failure. Thereby preventing entry into the completion >> handler(ath12k_dp_tx_completion_handler()). >> >> The existing design assumed that the ring numbers would always be >> sequential and could be directly mapped with the ring mask. However, >> this assumption does not hold true for WBM2SW ring-4. Therefore, >> modify the design such that, instead of mapping the ring number, >> the ring ID is mapped with the ring mask. >> >> According to this design: >> 1. During initialization of the WBM2SW ring, mapping the ring ID >> to the ring mask will ensure obtaining the correct ring mask group >> ID. >> 2. During runtime, validating the interrupted ring mask group ID >> within the transmission completion group is sufficient. This >> approach allows the ring ID to be derived from the interrupted ring >> mask and enables entry into the completion handler. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >> Tested-on: WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > should be > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Kalle can fix this in 'pending' Fixed. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
