Alexis Lothoré <alexis.lothore@xxxxxxxxxxx> writes: > Hello Kalle, > > On 5/14/24 14:45, Kalle Valo wrote: >> Alexis Lothoré <alexis.lothore@xxxxxxxxxxx> wrote: >> >>> net device registration is currently done in wilc_netdev_ifc_init but >>> other initialization operations are still done after this registration. >>> Since net device is assumed to be usable right after registration, it >>> should be the very last step of initialization. >>> >>> Move netdev registration at the very end of wilc_netdev_ifc_init to let >>> this function completely initialize netdevice before registering it. >>> >>> Signed-off-by: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx> >> >> I see errors: >> >> ERROR: modpost: "wilc_load_mac_from_nv" >> [drivers/net/wireless/microchip/wilc1000/wilc1000-sdio.ko] >> undefined! >> ERROR: modpost: "wilc_netdev_ifc_init" >> [drivers/net/wireless/microchip/wilc1000/wilc1000-sdio.ko] >> undefined! >> ERROR: modpost: "wilc_load_mac_from_nv" >> [drivers/net/wireless/microchip/wilc1000/wilc1000-spi.ko] undefined! >> ERROR: modpost: "wilc_netdev_ifc_init" >> [drivers/net/wireless/microchip/wilc1000/wilc1000-spi.ko] undefined! >> make[2]: *** [scripts/Makefile.modpost:145: Module.symvers] Error 1 >> make[1]: *** >> [/home/kvalo/projects/personal/wireless-drivers/src/wireless-next/Makefile:1871: >> modpost] Error 2 >> make: *** [Makefile:240: __sub-make] Error 2 >> >> 6 patches set to Changes Requested. >> >> 13633102 [1/6] wifi: wilc1000: set net device registration as last >> step during interface creation >> 13633103 [2/6] wifi: wilc1000: register net device only after bus >> being fully initialized >> 13633104 [3/6] wifi: wilc1000: set wilc_set_mac_address parameter as const >> 13633105 [4/6] wifi: wilc1000: add function to read mac address from eFuse >> 13633106 [5/6] wifi: wilc1000: make sdio deinit function really deinit the sdio card >> 13633107 [6/6] wifi: wilc1000: read MAC address from fuse at probe > > Shame on me, I missed those basic errors since I worked with drivers as built-in > instead of modules. I'll update my workflow and send a v2. No worries, but I'm surprised that Intel's kernel test robot didn't report anything. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
