On 5/6/2024 4:17 PM, Muna Sinada wrote: > Add support for dynamic VLAN. VLAN group traffic is encapsulated and > encrypted in mac80211 and driver needs to set flags for the VLAN group > traffic to skip hardware encapsulation and encryption. > > VLAN group traffic utilizes ext MSDU and HTT Metadata to set > encapsulation type to RAW and encryption type to OPEN in order to > inform firmware to skip hardware encapsulation and encryption. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Signed-off-by: Muna Sinada <quic_msinada@xxxxxxxxxxx> My first test of this patch gave intermittent connectivity, but a second test didn't show that, so I think my issues were actually with my home router. So giving this: Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> However I do have one question: > +struct hal_tx_msdu_metadata { > + __le32 info0; > + __le32 rsvd3[6]; why not rsvd0? If that is OK, Kalle can change this in 'pending' /jeff