On Mon, 2008-12-08 at 23:53 +0100, Ivo van Doorn wrote:
> On Monday 08 December 2008, Johannes Berg wrote:
> > The set_key callback now seems rather odd, passing a MAC address
> > instead of a station struct, and a local address instead of a
> > vif struct. Change that.
> >
> > Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
>
> ACK for the rt2x00 changes,
> I'm especially happy with the ieee80211_find_sta() removal from rt2x00. :)
>
> I'll see if I can test this in a few days,
Thanks
> One small change request though.
> Please move this bit up a bit to merge it with the address if-statement:
>
> if (sta) {
> crypto.address = sta->addr;
> crypto.aid = sta->aid
> } else
> crypto.address = bcast_addr;
>
> that would group the sta dependencies together so we only need to check
> if sta is valid once.
Sure, changed, see my patches folder, will resend after more
comments/testing.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
