On 4/23/2024 4:28 AM, Johannes Berg wrote:
On Tue, 2024-04-23 at 13:21 +0200, Johannes Berg wrote:
Anyway, I think I agree, but can you please add some validation of this
to cfg80211 as a first patch
I guess I should say what kind of validation? I think it'd make sense to
ensure that the elements even exist/are long enough (currently there's
no validation in nl80211_parse_mbssid_elems at all!!), perhaps call
validate_ie_attr() there as well.
Feels like something should also ensure that not only is
config->index < wiphy->mbssid_max_interfaces
but also actually < 2^max_bssid_indicator?
johannes
I agree with the validation concerns.
But the actual logic in this patch is valid, although considering we
have had this code for so many years now, feels like no driver/target
actually needs this field yet even though it is used :-)
